lili/OCCT
1
0
Fork 0
mirror of https://github.com/Open-Cascade-SAS/OCCT.git synced 2026-09-04 03:38:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Coding - Apply more flags from Clang-tidy (#977)

Browse Source 
- Refactor boolean expressions and improve code readability across multiple files
- Simplified boolean expressions by removing unnecessary comparisons to true/false.
- Replaced explicit boolean checks with direct variable usage 

Used flags:
readability-static-accessed-through-instance
readability-simplify-boolean-expr
performance-for-range-copy
performance-move-const-arg
misc-unused-parameters
misc-redundant-expression
This commit is contained in:
Pasukhin Dmitry
2026-01-03 12:18:59 +00:00
committed by GitHub
parent 825b0bd782
commit 6c24544fe1
582 changed files with 1535 additions and 3246 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ModelingAlgorithms/TKBool/TopOpeBRepBuild/TopOpeBRepBuild_BuilderON.cxx
+13 -16
View File
@@ -233,10 +233,7 @@ bool TopOpeBRepBuild_BuilderON::GFillONCheckI(const occ::handle<TopOpeBRepDS_Int
#endif
int rankFS = myPB->GShapeRank(FS);
int rankFOR = myPB->GShapeRank(myFace);
if (rankFS == 0 || rankFOR == 0)
return false;
return true;
return rankFS != 0 && rankFOR != 0;
} // GFillONCheckI
//=================================================================================================
@@ -1737,8 +1734,8 @@ void TopOpeBRepBuild_BuilderON::GFillONPartsWES2(const occ::handle<TopOpeBRepDS_
if (FCXisref && !EGBoundFOR)
{
FUN_tool_orientEinFFORWARD(EG, FCX, neworiE);
bool rev = myPB->Reverse(staFCX, staFOR);
neworiE = myPB->Orient(neworiE, rev);
bool rev = TopOpeBRepBuild_Builder::Reverse(staFCX, staFOR);
neworiE = TopOpeBRepBuild_Builder::Orient(neworiE, rev);
}
// xpu280798 : never occurs as yap1 -> !EGBoundFOR
// else if (FORisref && EGBoundFOR) {
@@ -1753,8 +1750,8 @@ void TopOpeBRepBuild_BuilderON::GFillONPartsWES2(const occ::handle<TopOpeBRepDS_
bool reverse = (M_FORWARD(neworiE) || M_REVERSED(neworiE)) && (!eONsoEsd);
if (reverse)
neworiE = TopAbs::Complement(neworiE);
bool rev = myPB->Reverse(staFOR, staFCX);
neworiE = myPB->Orient(neworiE, rev);
bool rev = TopOpeBRepBuild_Builder::Reverse(staFOR, staFCX);
neworiE = TopOpeBRepBuild_Builder::Orient(neworiE, rev);
}
else if (!EGBoundFOR)
{ // xpu210898
@@ -1769,8 +1766,8 @@ void TopOpeBRepBuild_BuilderON::GFillONPartsWES2(const occ::handle<TopOpeBRepDS_
if (reverse)
neworiE = TopAbs::Complement(neworiE);
}
bool rev = myPB->Reverse(staFOR, staFCX);
neworiE = myPB->Orient(neworiE, rev);
bool rev = TopOpeBRepBuild_Builder::Reverse(staFOR, staFCX);
neworiE = TopOpeBRepBuild_Builder::Orient(neworiE, rev);
}
TopoDS_Shape newE = EspON;
@@ -2296,8 +2293,8 @@ void TopOpeBRepBuild_BuilderON::GFillONPartsWES2(const occ::handle<TopOpeBRepDS_
if (FCXisref && !EGBoundFOR)
{
FUN_tool_orientEinFFORWARD(EG, FCX, neworiE);
bool rev = myPB->Reverse(staFCX, staFOR);
neworiE = myPB->Orient(neworiE, rev);
bool rev = TopOpeBRepBuild_Builder::Reverse(staFCX, staFOR);
neworiE = TopOpeBRepBuild_Builder::Orient(neworiE, rev);
}
else if (FORisref && !EGBoundFOR)
{
@@ -2308,8 +2305,8 @@ void TopOpeBRepBuild_BuilderON::GFillONPartsWES2(const occ::handle<TopOpeBRepDS_
bool reverse = (M_FORWARD(neworiE) || M_REVERSED(neworiE)) && (!eONsoEsd);
if (reverse)
neworiE = TopAbs::Complement(neworiE);
bool rev = myPB->Reverse(staFOR, staFCX);
neworiE = myPB->Orient(neworiE, rev);
bool rev = TopOpeBRepBuild_Builder::Reverse(staFOR, staFCX);
neworiE = TopOpeBRepBuild_Builder::Orient(neworiE, rev);
}
else if (!EGBoundFOR)
{
@@ -2325,8 +2322,8 @@ void TopOpeBRepBuild_BuilderON::GFillONPartsWES2(const occ::handle<TopOpeBRepDS_
if (reverse)
neworiE = TopAbs::Complement(neworiE);
}
bool rev = myPB->Reverse(staFOR, staFCX);
neworiE = myPB->Orient(neworiE, rev);
bool rev = TopOpeBRepBuild_Builder::Reverse(staFOR, staFCX);
neworiE = TopOpeBRepBuild_Builder::Orient(neworiE, rev);
}
TopoDS_Shape newE = EspON;