Coding - Apply more flags from Clang-tidy (#977)

- Refactor boolean expressions and improve code readability across multiple files
- Simplified boolean expressions by removing unnecessary comparisons to true/false.
- Replaced explicit boolean checks with direct variable usage 

Used flags:
readability-static-accessed-through-instance
readability-simplify-boolean-expr
performance-for-range-copy
performance-move-const-arg
misc-unused-parameters
misc-redundant-expression
This commit is contained in:
Pasukhin Dmitry
2026-01-03 12:18:59 +00:00
committed by GitHub
parent 825b0bd782
commit 6c24544fe1
582 changed files with 1535 additions and 3246 deletions

View File

@@ -172,7 +172,7 @@ static BinTools_OStream& operator<<(BinTools_OStream& OS, const occ::handle<Geom
static BinTools_OStream& operator<<(BinTools_OStream& OS, const occ::handle<Geom2d_BezierCurve>& B)
{
OS << (uint8_t)BEZIER;
bool aRational = B->IsRational() ? true : false;
bool aRational = B->IsRational();
OS << aRational; // rational
// poles and weights
int i, aDegree = B->Degree();
@@ -194,9 +194,9 @@ static BinTools_OStream& operator<<(BinTools_OStream& OS, const occ::handle<Geom
static BinTools_OStream& operator<<(BinTools_OStream& OS, const occ::handle<Geom2d_BSplineCurve>& B)
{
OS << (uint8_t)BSPLINE;
bool aRational = B->IsRational() ? true : false;
bool aRational = B->IsRational();
OS << aRational; // rational
bool aPeriodic = B->IsPeriodic() ? true : false;
bool aPeriodic = B->IsPeriodic();
OS << aPeriodic; // periodic
// poles and weights
int i, aDegree, aNbPoles, aNbKnots;

View File

@@ -177,7 +177,7 @@ static BinTools_OStream& operator<<(BinTools_OStream& OS, const occ::handle<Geom
static BinTools_OStream& operator<<(BinTools_OStream& OS, const occ::handle<Geom_BezierCurve>& B)
{
OS << (uint8_t)BEZIER;
bool aRational = B->IsRational() ? true : false;
bool aRational = B->IsRational();
OS << aRational; // rational
// poles and weights
int i, aDegree = B->Degree();
@@ -199,9 +199,9 @@ static BinTools_OStream& operator<<(BinTools_OStream& OS, const occ::handle<Geom
static BinTools_OStream& operator<<(BinTools_OStream& OS, const occ::handle<Geom_BSplineCurve>& B)
{
OS << (uint8_t)BSPLINE;
bool aRational = B->IsRational() ? true : false;
bool aRational = B->IsRational();
OS << aRational; // rational
bool aPeriodic = B->IsPeriodic() ? true : false;
bool aPeriodic = B->IsPeriodic();
OS << aPeriodic; // periodic
// poles and weights
int i, aDegree, aNbPoles, aNbKnots;

View File

@@ -124,7 +124,7 @@ TopAbs_Orientation BinTools_IStream::ShapeOrientation()
BinTools_IStream::operator bool() const
{
return *myStream ? true : false;
return static_cast<bool>(*myStream);
}
//=======================================================================

View File

@@ -320,13 +320,13 @@ void BinTools_ShapeSet::Write(Standard_OStream& OS, const Message_ProgressRange&
WriteShape(S, OS);
// Flags
BinTools::PutBool(OS, S.Free() ? true : false);
BinTools::PutBool(OS, S.Modified() ? true : false);
BinTools::PutBool(OS, S.Checked() ? true : false);
BinTools::PutBool(OS, S.Orientable() ? true : false);
BinTools::PutBool(OS, S.Closed() ? true : false);
BinTools::PutBool(OS, S.Infinite() ? true : false);
BinTools::PutBool(OS, S.Convex() ? true : false);
BinTools::PutBool(OS, S.Free());
BinTools::PutBool(OS, S.Modified());
BinTools::PutBool(OS, S.Checked());
BinTools::PutBool(OS, S.Orientable());
BinTools::PutBool(OS, S.Closed());
BinTools::PutBool(OS, S.Infinite());
BinTools::PutBool(OS, S.Convex());
// sub-shapes
@@ -609,11 +609,11 @@ void BinTools_ShapeSet::WriteShape(const TopoDS_Shape& S, Standard_OStream& OS)
BinTools::PutReal(OS, TE->Tolerance());
bool aVal = (TE->SameParameter()) ? true : false;
bool aVal = TE->SameParameter();
BinTools::PutBool(OS, aVal);
aVal = (TE->SameRange()) ? true : false;
aVal = TE->SameRange();
BinTools::PutBool(OS, aVal);
aVal = (TE->Degenerated()) ? true : false;
aVal = TE->Degenerated();
BinTools::PutBool(OS, aVal);
double first, last;
@@ -1428,10 +1428,10 @@ void BinTools_ShapeSet::WriteTriangulation(Standard_OStream& OS,
const int aNbTriangles = aTriangulation->NbTriangles();
BinTools::PutInteger(OS, aNbNodes);
BinTools::PutInteger(OS, aNbTriangles);
BinTools::PutBool(OS, aTriangulation->HasUVNodes() ? true : false);
BinTools::PutBool(OS, aTriangulation->HasUVNodes());
if (FormatNb() >= BinTools_FormatVersion_VERSION_4)
{
BinTools::PutBool(OS, (aTriangulation->HasNormals() && NeedToWriteNormals) ? true : false);
BinTools::PutBool(OS, aTriangulation->HasNormals() && NeedToWriteNormals);
}
BinTools::PutReal(OS, aTriangulation->Deflection());

View File

@@ -210,8 +210,8 @@ static BinTools_OStream& operator<<(BinTools_OStream&
static BinTools_OStream& operator<<(BinTools_OStream& OS, const occ::handle<Geom_BezierSurface>& S)
{
OS << (uint8_t)BEZIER;
bool urational = S->IsURational() ? true : false;
bool vrational = S->IsVRational() ? true : false;
bool urational = S->IsURational();
bool vrational = S->IsVRational();
OS << urational; // rational
OS << vrational;
@@ -243,10 +243,10 @@ static BinTools_OStream& operator<<(BinTools_OStream& OS, const occ::handle<Geom
static BinTools_OStream& operator<<(BinTools_OStream& OS, const occ::handle<Geom_BSplineSurface>& S)
{
OS << (uint8_t)BSPLINE;
bool urational = S->IsURational() ? true : false;
bool vrational = S->IsVRational() ? true : false;
bool uperiodic = S->IsUPeriodic() ? true : false;
bool vperiodic = S->IsVPeriodic() ? true : false;
bool urational = S->IsURational();
bool vrational = S->IsVRational();
bool uperiodic = S->IsUPeriodic();
bool vperiodic = S->IsVPeriodic();
OS << urational;
OS << vrational;
OS << uperiodic;