lili/OCCT
1
0
Fork 0
mirror of https://github.com/Open-Cascade-SAS/OCCT.git synced 2026-05-10 01:20:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Shape Healing - Crash in ShapeConstruct_ProjectCurveOnSurface::insertAdditionalPointOrAdjust() (#1267)

Browse Source 
To input parameters of ShapeConstruct_ProjectCurveOnSurface::insertAdditionalPointOrAdjust() new arrays were assigned. The size of new arrays are guaranteed to be 1 element larger that original array. NCollection_Array1::Assign() is guaranteed to throw exception when arrays size mismatch. So, given that assignment code is reached, function will always throw.
Fixed by calling move assignment instead - size mismatch is allowed in this case. Also it is more optimal.
This commit is contained in:
Dmitrii Kulikov
2026-05-05 18:16:32 +01:00
committed by GitHub
parent 9281002280
commit 6f6be66842
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/ModelingAlgorithms/TKShHealing/ShapeConstruct/ShapeConstruct_ProjectCurveOnSurface.cxx
View File

@@ -2129,9 +2129,9 @@ void ShapeConstruct_ProjectCurveOnSurface::insertAdditionalPointOrAdjust(
aNewPoints2d.SetValue(i + 1, thePoints2d(i)); aNewPoints2d.SetValue(i + 1, thePoints2d(i));
} }
thePoints = aNewPoints; thePoints = std::move(aNewPoints);
theParams = aNewParams; theParams = std::move(aNewParams);
thePoints2d = aNewPoints2d; thePoints2d = std::move(aNewPoints2d);
theIndex++; theIndex++;
} }
else else