lili/OCCT
1
0
Fork 0
mirror of https://github.com/Open-Cascade-SAS/OCCT.git synced 2026-07-10 04:17:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Shape Healing - Unstable PCurve Processing (#967)

Browse Source 
Added hot fix to keep old logic (loop were skipped).
Added TODO to fix for the ongoing release.
The ticket is added #966 in GH Issues.
This commit is contained in:
Pasukhin Dmitry
2025-12-29 15:15:10 +00:00
committed by GitHub
parent c020fc2fad
commit a509566a28
1 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/ModelingAlgorithms/TKShHealing/ShapeUpgrade/ShapeUpgrade_UnifySameDomain.cxx
View File

@@ -1578,19 +1578,22 @@ static TopoDS_Edge GlueEdgesWithPCurves(const NCollection_Sequence<TopoDS_Shape>
NCollection_Sequence<occ::handle<Geom_Surface>> SurfSeq;
NCollection_Sequence<TopLoc_Location> LocSeq;
for (int aCurveIndex = 1;; aCurveIndex++)
{
occ::handle<Geom2d_Curve> aCurve;
occ::handle<Geom_Surface> aSurface;
TopLoc_Location aLocation;
double aFirst, aLast;
BRep_Tool::CurveOnSurface(FirstEdge, aCurve, aSurface, aLocation, aFirst, aLast, aCurveIndex);
if (aCurve.IsNull())
break;
// TODO: Issue (#966) Code is not working correctly
// All previous versions were relying that that loop never reach end and break on start,
// because it was starting from 0 and 0st is not existing curve index.
// for (int aCurveIndex = 1;; aCurveIndex++)
// {
// occ::handle<Geom2d_Curve> aCurve;
// occ::handle<Geom_Surface> aSurface;
// TopLoc_Location aLocation;
// double aFirst, aLast;
// BRep_Tool::CurveOnSurface(FirstEdge, aCurve, aSurface, aLocation, aFirst, aLast,
// aCurveIndex); if (aCurve.IsNull())
// continue;
SurfSeq.Append(aSurface);
LocSeq.Append(aLocation);
}
// SurfSeq.Append(aSurface);
// LocSeq.Append(aLocation);
// }
double fpar, lpar;
BRep_Tool::Range(FirstEdge, fpar, lpar);