lili/amodem
1
0
Fork 0
mirror of https://github.com/romanz/amodem.git synced 2026-04-21 05:36:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

server: don't use shell=True on default

Browse Source
This commit is contained in:
Roman Zeyde
2015-07-04 09:24:10 +03:00
parent dcfc88c7e1
commit 93bac8b011
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sshagent/server.py
View File

@@ -84,12 +84,12 @@ def serve(public_keys, signer, sock_path=None):
server.shutdown(socket.SHUT_RD) server.shutdown(socket.SHUT_RD)
def run_process(command, environ): def run_process(command, environ, use_shell=False):
log.debug('running %r with %r', command, environ) log.debug('running %r with %r', command, environ)
env = dict(os.environ) env = dict(os.environ)
env.update(environ) env.update(environ)
try: try:
p = subprocess.Popen(args=command, env=env, shell=True) p = subprocess.Popen(args=command, env=env, shell=use_shell)
except OSError as e: except OSError as e:
raise OSError('cannot run %r: %s' % (command, e)) raise OSError('cannot run %r: %s' % (command, e))
log.debug('subprocess %d is running', p.pid) log.debug('subprocess %d is running', p.pid)