From 4d47755cb4bd2b017bd586fae5267ef5697e27b0 Mon Sep 17 00:00:00 2001 From: Lewis Moten Date: Fri, 17 May 2024 16:47:47 -0400 Subject: [PATCH] don't trust crc when size is zero --- StreamManager.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/StreamManager.js b/StreamManager.js index 5cebb77..228eafd 100644 --- a/StreamManager.js +++ b/StreamManager.js @@ -90,7 +90,7 @@ export const applyPacket = ({ const dataSize = PacketUtils.getPacketDataByteCount(); const offset = sequence * dataSize; const length = offset + dataSize; - if(crc === actualCrc) { + if(crc === actualCrc && size !== 0) { if(FAILED_SEQUENCES.includes(sequence)) { FAILED_SEQUENCES.splice(FAILED_SEQUENCES.indexOf(sequence), 1); } @@ -178,7 +178,10 @@ export const getSizeAvailable = () => { } export const isSizeTrusted = () => { if(!getSizeAvailable()) return false; - if(DATA_SIZE_CRC_BIT_COUNT !== 0) return getSizeCrcPassed(); + if(DATA_SIZE_CRC_BIT_COUNT !== 0) { + if(getSize() === 0) return false; + return getSizeCrcPassed(); + } return true; } export const getSize = () => {