From 23cf42d87a0db080a4dd4977e144d5ebbe33fbfa Mon Sep 17 00:00:00 2001 From: hjk Date: Wed, 29 Oct 2025 14:14:42 +0100 Subject: [PATCH] Disable Axivion reports for Qt-FunctionArgsByValueRef This is an unfortunate combination of clazy-function-args-by-ref and clazy-function-args-by-value. function-args-by-ref fixes are almost always safe to apply. They actually may save an unbounded amount of cycles, and there are typically only a few of them. On the other hand, function-args-by-value is a mixed bag: There are a lot of them and the expected gain is small: It's typically trading one or two register for one register and a "hot" location on the stack. Especially when passing down such objects to a through a sequence of function calls this is not even necessarily a clear win on all architecture. In any case it should be considered that especially in the Qt context changing signatures of public functions is not cheap, if possible at all. Change-Id: I281ea086fb15e0a045316591d9af620b5e730f4a Reviewed-by: Matti Paaso Reviewed-by: Alex Blasche --- coin/provisioning/common/linux/axivion/rule_config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coin/provisioning/common/linux/axivion/rule_config.json b/coin/provisioning/common/linux/axivion/rule_config.json index 80330c3c..cd4b7724 100644 --- a/coin/provisioning/common/linux/axivion/rule_config.json +++ b/coin/provisioning/common/linux/axivion/rule_config.json @@ -60,7 +60,7 @@ "_active": true }, "Qt-FunctionArgsByValueRef": { - "_active": true + "_active": false }, "Qt-Generic-DuplicateIncludeGuard": { "_active": true