mirror of
git://code.qt.io/qt/qt5.git
synced 2026-04-20 03:46:44 +08:00
Fix configure -init-submodules ignoring -skip option
When running configure -init-submodules -skip <module>, the -skip
option was ignored because init-repository ran before -skip values
were processed. The skipped modules were still initialized.
Fix by preprocessing -skip values in qt_tl_run_main_script() before
calling qt_ir_run_main_script(). The -skip values are converted to
module-subset exclusions (e.g. -qtwebengine) and merged with the
existing module-subset option.
Also register -skip as a known option in init-repository so it can
be parsed from the optfile.
Fixes: QTBUG-140359
Pick-to: 6.10 6.8
Change-Id: I37ed916dd1c22b6d10d23821044fee807919d4a9
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
(cherry picked from commit 378c8719a9)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
committed by
Qt Cherry-pick Bot
parent
546bcebdaa
commit
b2fb8279dc
@@ -89,6 +89,26 @@ function(qt_ir_handle_called_from_configure top_level_src_path out_var_exit_reas
|
||||
|
||||
qt_ir_validate_options_for_configure()
|
||||
|
||||
# Convert -skip values to module-subset exclusions so init-repository respects them.
|
||||
qt_ir_get_option_value(skip skip_modules)
|
||||
if(skip_modules)
|
||||
string(REPLACE "," ";" skip_modules "${skip_modules}")
|
||||
list(TRANSFORM skip_modules STRIP)
|
||||
list(TRANSFORM skip_modules PREPEND "-")
|
||||
|
||||
qt_ir_get_option_value(module-subset existing_subset)
|
||||
if(NOT existing_subset)
|
||||
set(existing_subset "default")
|
||||
endif()
|
||||
|
||||
list(APPEND skip_modules "${existing_subset}")
|
||||
list(REMOVE_DUPLICATES skip_modules)
|
||||
list(JOIN skip_modules "," merged_subset)
|
||||
|
||||
qt_ir_set_option_value(module-subset "${merged_subset}")
|
||||
message(DEBUG "Preprocessed -skip option: module-subset is now: ${merged_subset}")
|
||||
endif()
|
||||
|
||||
# -init_submodules implies --force
|
||||
qt_ir_set_option_value(force TRUE)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user