lili/ggwave
1
0
Fork 0
mirror of https://github.com/ggerganov/ggwave.git synced 2026-02-24 16:16:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

ggwave-gui : fix input buffer overflow

Browse Source
This commit is contained in:
Georgi Gerganov
2020-12-12 16:15:44 +02:00
parent 57572ec57d
commit 12b63a6d7c
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
examples/ggwave-gui/common.h
View File

@@ -21,6 +21,7 @@
#define ICON_FA_SIGNAL ""
#define ICON_FA_PLAY_CIRCLE ""
#define ICON_FA_ARROW_CIRCLE_DOWN "V"
#define ICON_FA_PASTE "P"
#endif
struct Message {
@@ -214,7 +215,8 @@ void renderMain() {
static WindowId windowId = WindowId::Messages;
static Settings settings;
static char inputBuf[256];
const int kMaxInputSize = 140;
static char inputBuf[kMaxInputSize];
static bool doInputFocus = false;
static bool lastMouseButtonLeft = 0;
@@ -502,8 +504,14 @@ void renderMain() {
ImGui::SetKeyboardFocusHere();
doInputFocus = false;
}
if (ImGui::Button(ICON_FA_PASTE)) {
for (int i = 0; i < kMaxInputSize; ++i) inputBuf[i] = 0;
strncpy(inputBuf, SDL_GetClipboardText(), kMaxInputSize - 1);
}
ImGui::SameLine();
ImGui::PushItemWidth(ImGui::GetContentRegionAvailWidth() - ImGui::CalcTextSize(sendButtonText).x - 2*style.ItemSpacing.x);
ImGui::InputText("##Messages:Input", inputBuf, 256, ImGuiInputTextFlags_EnterReturnsTrue);
ImGui::InputText("##Messages:Input", inputBuf, kMaxInputSize, ImGuiInputTextFlags_EnterReturnsTrue);
ImGui::PopItemWidth();
if (ImGui::IsItemActive() && isTextInput == false) {
SDL_StartTextInput();